This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
Support for Mir integration #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergefdrv
force-pushed
the
2-improve-join-and-leave-to-support-mir
branch
from
7f3c18d to
a83ee57
Compare
sergefdrv
force-pushed
the
2-improve-join-and-leave-to-support-mir
branch
from
a83ee57 to
2baab6e
Compare
|
@dnkolegov I requested your review just to double-check that everything you need for Mir is supported |
dnkolegov
approved these changes
Oct 10, 2022
adlrocha
approved these changes
Oct 10, 2022
| addr: addr.clone(), | ||
| // FIXME: Receive address in params | ||
| net_addr: String::new(), | ||
| net_addr: String::from(net_addr), |
There was a problem hiding this comment.
We should consider checking if this is a multiaddr. We should only support multiaddr for this. We can add a TODO and then consider it for the integration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.