Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue parsing embedded strings #15

Closed
murpheywa opened this issue Sep 27, 2022 · 2 comments · Fixed by #16
Closed

Issue parsing embedded strings #15

murpheywa opened this issue Sep 27, 2022 · 2 comments · Fixed by #16
Labels
hacktoberfest hacktoberfest-accepted

Comments

@murpheywa
Copy link

Given this valid JSON

{
	"jo": "{\"url\":\"http://foo.bar\"}"
}

Comment::strip() returns

{
        "js": "{\"url\":\"http:
}
@adhocore
Copy link
Owner

issue just confirmed, thanks for reporting. will be fixed in a few days.

@adhocore adhocore mentioned this issue Oct 1, 2022
Merged
@adhocore
Copy link
Owner

adhocore commented Oct 1, 2022

fixed in #16 n released as v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: json string inside json with comment like value breaks adhocore/php-json-comment
2 participants
@adhocore @murpheywa