-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding 2 Types in ReproParturitionEventResource #191
Comments
This is also one of the things we are missing compared to previous exchange standard using in our systems (NordicNDX). BirthSize and BirthStatus are the parameters what needs to be passed on progeny level, but for progeny we have an array of icalAnimalCoreResource -resources defined in a message. One solution would be to extend icalAnimalCoreResource with new fields, but I'm not sure is it a proper way of solving that. Another way is to define new type aka icarAnimalBirthResource/Type (inherited from icalAnimalCoreResource ) and have it as progeny message. Then we can add required fields there |
both solutions are usable for us. We need this info to create the parturition correct. |
We would like to have the values above added to the standard. In case of birthSize we would add another value "average" for countres where it is needed. For the birthState we think it would be good to have only one set of values and everyone should pick the values which ar needed. Would this be a solution also to other EnumValues in the ADE standard? |
We would collect multiple events/types at birth:
Each value would be recorded against the calf |
At birth we collect: |
In Finland we use following during parturition: CalvingEase:
BirthStatus:
|
In Germany we use CalvingEase:
BirthStatus
destination of calve
|
Proposed solution as follows:
Content of icarProgenyDetailsType
Extensible to cover other scores recorded by specific countries, or as agreed by this group. |
I like this solution and strongly voting for it. I can prepare first PR draft with proposed changes and try to prepare a common list of all possible birth/size statuses mentioned in current thread. Then we can adjust the PR changes toward ideality. :) |
Draft PR is added and could be commented #243 |
@cookeac @erwinspeybroeck I even think if we can just use this new "ProgenyDetails" as an "extension" for the core animal resource. By having new type inherited from "icarAnimalCoreResource" we'll remain all original animal properties and add new without "breaking" a core resource. In general we can use the same "progeny" property in parturition resource as technically it the same type but extended a bit... |
Added small updates for #243
|
I've made my PR available for official review and we can now target it to the next ADE release. |
PR is merged to the Development branch, issue is closed |
Hi
We will make local additions in ReproParturitionEventResource
"progenyBirthsizeType" with following selections:
Little
Below average
Above average
Big
and
"progenyStateofbirthType" with following selections:
Defective calf
Live calf
Live calf, born prematurely
Died within 1 day
Died after 1 day
Stillborn
Abortion
Culled at birth
To accept a parturition theese input will required from our side.
Maybe you're considering being added to ADE?
The text was updated successfully, but these errors were encountered: