Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown types should be marked as unknown and not any #29

Closed
kylemilloy opened this issue Mar 10, 2023 · 1 comment · Fixed by #30
Closed

Unknown types should be marked as unknown and not any #29

kylemilloy opened this issue Mar 10, 2023 · 1 comment · Fixed by #30

Comments

@kylemilloy
Copy link
Contributor

kylemilloy commented Mar 10, 2023 •
edited
Loading

For TypeScript v3 or higher we should be using unknown as a type instead of any when we can't find an appropriate type to map to. You can view the TypeScript PR that introduces unknown and its purpose here.

PR incoming....
@kylemilloy kylemilloy mentioned this issue Mar 10, 2023
Merged
@kylemilloy
Copy link
Contributor Author

Opened a draft for discussion. @adenh93 let me know if you have any questions or concerns and I can make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kylemilloy