Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate runtime-only dependencies into their own package #91

Closed
adelsz opened this issue May 30, 2020 · 4 comments
Closed

Isolate runtime-only dependencies into their own package #91

adelsz opened this issue May 30, 2020 · 4 comments

Comments

@adelsz
Copy link
Owner

adelsz commented May 30, 2020

It would be nice to move runtime query dependencies into a separate package.
Currently @pgtyped/query has both runtime and compile time logic in it.

@gregplaysguitar
Copy link

@adelsz is there a way we could help out with this piece of work? My team is looking at ways to reduce the size of dependencies for our lambdas, and typescript via pgtyped is one of the larger ones.

@m-ronchi
Copy link

m-ronchi commented Apr 1, 2022

+1 I just found out that for some of my apps, typescipt alone is bigger that the rest of production node_modules combined, resulting in a 200MB+ docker image. this is especially bad because I only have queries in sql files

any plans on this?

@gregplaysguitar
Copy link

@adelsz from investigation here it seems that typescript is no longer a dependency of @pgtyped/query, so looks like this is resolved - so I think it can be closed?

@adelsz adelsz mentioned this issue Jan 24, 2023
@adelsz
Copy link
Owner Author

adelsz commented Jan 28, 2023

This has been fixed as part of our migration to ESM.

@adelsz adelsz closed this as completed Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants