Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global to Adapt plugins: Placeholder image alt text #2939

Closed
kirsty-hames opened this issue Oct 9, 2020 · 2 comments · Fixed by #2986
Closed

Global to Adapt plugins: Placeholder image alt text #2939

kirsty-hames opened this issue Oct 9, 2020 · 2 comments · Fixed by #2986

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

Do we need to include placeholder alt text in example.json files? I often find this doesn't get removed from courses unless it's being replaced.

              "_graphic": {
                  "src": "course/en/images/example.jpg",
                  "alt": "Placeholder graphic",
                  "attribution": "Copyright © 2019"
              }

When an alt attribute is left empty the image is ignored and I think this would be a more suitable default. It's more of a nuisance to include alt text when not needed never mind placeholder text. In most use cases, an image is decorative or content is already covered by the display text.

I would suggest a _comment attribute in the example.json or improve the description in the README (e.g. What alt text is and when to use it.)

Plus, we wouldn't need to include 'graphic' in image alt text so we're setting a bad example.

Plugins this relates to

Accordion https://github.com/adaptlearning/adapt-contrib-accordion/blob/master/example.json
GMCQ https://github.com/adaptlearning/adapt-contrib-gmcq/blob/master/example.json
Graphic https://github.com/adaptlearning/adapt-contrib-graphic/blob/master/example.json
Hotgraphic https://github.com/adaptlearning/adapt-contrib-hotgraphic/blob/master/example.json
Narrative https://github.com/adaptlearning/adapt-contrib-narrative/blob/master/example.json
Boxmenu https://github.com/adaptlearning/adapt-contrib-boxmenu/blob/master/example.json

@oliverfoster
Copy link
Member

oliverfoster commented Oct 9, 2020

Yes - I agree, no we don't need default placeholder text...

@kirsty-hames
Copy link
Contributor Author

kirsty-hames commented Oct 13, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants