Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: included scale step in input slider jsx (fix #187) #190

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix: included scale step in input slider jsx (fix #187) #190

merged 1 commit into from
Jul 20, 2023

Conversation

ethan-lp
Copy link
Contributor

@ethan-lp ethan-lp commented Jul 19, 2023 •
edited
Loading

#187

Fix

_scaleStep included in props and assigned to steps within the input slider. This will ensure correct increment/decrement when scale step is above 1.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 19, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

swashbuck
swashbuck approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swashbuck swashbuck added the bug label Jul 19, 2023
@cahirodoherty-learningpool cahirodoherty-learningpool merged commit 4c9df59 into adaptlearning:master Jul 20, 2023
github-actions bot pushed a commit that referenced this pull request Jul 20, 2023
@semantic-release-bot
Chore(release): 4.3.8 [skip ci]
ac1299f 
## [4.3.8](v4.3.7...v4.3.8) (2023-07-20)

### Fix

* included scale step in input slider jsx (fix #187) (#190) ([4c9df59](4c9df59)), closes [#187](#187) [#190](#190)

### Upgrade

* Bump yaml and semantic-release (#188) ([aa11148](aa11148)), closes [#188](#188)
@github-actions
Copy link

🎉 This PR is included in version 4.3.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@swashbuck swashbuck swashbuck approved these changes

@oliverfoster oliverfoster Awaiting requested review from oliverfoster

Assignees

@ethan-lp ethan-lp

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethan-lp @swashbuck @cahirodoherty-learningpool @eleanor-heath