Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: String defaults for scaleStepPrefix and scaleStepSuffix #186

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fix: String defaults for scaleStepPrefix and scaleStepSuffix #186

merged 1 commit into from
Apr 18, 2023

Conversation

oliverfoster
Copy link
Member

fixes #185

Fix

  • Provided string defaults to stop jsx converting undefined to "undefined"

@oliverfoster oliverfoster requested a review from swashbuck April 18, 2023 10:46
@oliverfoster oliverfoster self-assigned this Apr 18, 2023
swashbuck
swashbuck approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 3de631c into master Apr 18, 2023
@oliverfoster oliverfoster deleted the issue/185 branch April 18, 2023 17:50
github-actions bot pushed a commit that referenced this pull request Apr 18, 2023
@semantic-release-bot
Chore(release): 4.3.7 [skip ci]
fdb43aa 
## [4.3.7](v4.3.6...v4.3.7) (2023-04-18)

### Fix

* String defaults for scaleStepPrefix and scaleStepSuffix (#186) ([3de631c](3de631c)), closes [#186](#186)
@github-actions
Copy link

🎉 This PR is included in version 4.3.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix/suffix inducing string output or undefined
3 participants
@oliverfoster @swashbuck @kirsty-hames