Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to suppress false positives for certain checks in certain locations #93

Open
kwin opened this issue May 3, 2023 · 1 comment
Open

Comments

@kwin
Copy link

kwin commented May 3, 2023

How can the rules outlined at https://experienceleague.adobe.com/docs/experience-manager-cloud-manager/content/using/custom-code-quality-rules.html?lang=en#product-apis-annotated-with-providertype-should-not-be-implemented-or-extended-by-customers be ignored/suppressed on specific code?

As OakPal acts on binary artifacts if I understand correctly using @SuppressWarning cannot be used. Any other way of e.g. ignoring CQBP-84 (in case no implementation of a ProviderType interface is exported yet and cannot be retrieved either, like for example for com.day.cq.dam.scene7.api.model.Scene7NormalizedCropRect which is used in com.day.cq.dam.scene7.api.model.Scene7Service.updateSmartCrops(...) there doesn't exist any wrapper/implementation that can be used.

@kwin
Copy link
Author

kwin commented May 3, 2023

One idea would be evaluating an additional metadata file inside the content package (e.g. META-INF/oakpal/suppressions.xml) which could be used for suppressing certain checks in certain locations.

@kwin kwin changed the title How to suppress false positives? How to suppress false positives for certain checks in certain locations? May 3, 2023
@kwin kwin changed the title How to suppress false positives for certain checks in certain locations? Allow to suppress false positives for certain checks in certain locations May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant