From 34ae012bce5885ed0d465b8567ded8bc4f086929 Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Sun, 19 Mar 2023 08:44:08 +0000 Subject: [PATCH] Improve documentation (#492) --- README.rst | 38 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/README.rst b/README.rst index 277b333..4f08115 100644 --- a/README.rst +++ b/README.rst @@ -47,6 +47,12 @@ Rules C400-402: Unnecessary generator - rewrite as a ```` comprehension. --------------------------------------------------------------------------------- +Rules: + +* C400 Unnecessary generator - rewrite as a list comprehension. +* C401 Unnecessary generator - rewrite as a set comprehension. +* C402 Unnecessary generator - rewrite as a dict comprehension. + It's unnecessary to use ``list``, ``set``, or ``dict`` around a generator expression, since there are equivalent comprehensions for these types. For example: @@ -57,6 +63,11 @@ For example: C403-404: Unnecessary list comprehension - rewrite as a ```` comprehension. ------------------------------------------------------------------------------------- +Rules: + +* C403 Unnecessary list comprehension - rewrite as a set comprehension. +* C404 Unnecessary list comprehension - rewrite as a dict comprehension. + It's unnecessary to use a list comprehension inside a call to ``set`` or ``dict``, since there are equivalent comprehensions for these types. For example: @@ -66,6 +77,9 @@ For example: C405-406: Unnecessary ```` literal - rewrite as a ```` literal. ------------------------------------------------------------------------------------- +* C405 Unnecessary ```` literal - rewrite as a set literal. +* C406 Unnecessary ```` literal - rewrite as a dict literal. + It's unnecessary to use a list or tuple literal within a call to ``set`` or ``dict``. For example: @@ -76,6 +90,11 @@ For example: * Rewrite ``dict(((1, 2),))`` as ``{1: 2}`` * Rewrite ``dict([])`` as ``{}`` +C407: Unnecessary ```` comprehension - ```` can take a generator +------------------------------------------------------------------------------------ + +This rule was dropped in version 3.4.0, because it promoted an increase in laziness which could lead to bugs. + C408: Unnecessary ```` call - rewrite as a literal. -------------------------------------------------------------------- @@ -88,8 +107,18 @@ For example: * Rewrite ``list()`` as ``[]`` * Rewrite ``tuple()`` as ``()`` -C409-410: Unnecessary ```` passed to ````\() - (remove the outer call to ````()/rewrite as a ```` literal). ------------------------------------------------------------------------------------------------------------------------------------------------------------ +C409-410: Unnecessary ```` passed to ````\() - ````. +------------------------------------------------------------------------------------ + +Rules: + +* C409 Unnecessary ```` passed to tuple() - ````. +* C410 Unnecessary ``list passed to list() - ````. + +Where ```` is either: + +* remove the outer call to ````\() +* rewrite as a ```` literal It's unnecessary to use a list or tuple literal within a call to ``list`` or ``tuple``, since there is literal syntax for these types. For example: @@ -109,6 +138,11 @@ For example: * Rewrite ``list([f(x) for x in foo])`` as ``[f(x) for x in foo]`` +C412: Unnecessary ```` comprehension - 'in' can take a generator. +-------------------------------------------------------------------------------- + +This rule was dropped in version 3.4.0, because it promoted an increase in laziness which could lead to bugs. + C413: Unnecessary ```` call around sorted(). -----------------------------------------------------------