Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to get fix to MIDI sys ex #84

Closed
mzero opened this issue Dec 1, 2020 · 8 comments
Closed

update to get fix to MIDI sys ex #84

mzero opened this issue Dec 1, 2020 · 8 comments

Comments

@mzero
Copy link
Contributor

mzero commented Dec 1, 2020

Adafruit cores that incorporate this variant of the TinyUSB stack have a serious bug that renders it impossible to send MIDI SysEx messages.

The bug was fixed in TinyUSB back in september... but must get pulled in here first, then pulled into relevant cores, to create working base for users' sketches.

I'm hoping that see the fixed TinyUSB can be merged here... so that we can eventually have cores that work for sending MIDI Sys Ex.

@hathach
Copy link
Member

hathach commented Dec 1, 2020

Hi, would you mind telling me which board you are using samd or nrf ?

@mzero
Copy link
Contributor Author

mzero commented Dec 1, 2020

I'm using the SAMD core - https://github.com/adafruit/ArduinoCore-samd

@mzero
Copy link
Contributor Author

mzero commented Dec 14, 2020

I looks like the code in ArduinoCore-samd is getting ready for the next release... it would be great if we could get this in there.

@hathach
Copy link
Member

hathach commented Dec 14, 2020

I am off for vacation. Will be back after a week. Will check it out later then

@hathach
Copy link
Member

hathach commented Dec 15, 2020

Though you don't gave to worry about catching up with release. We do release whenever it needs

@mzero
Copy link
Contributor Author

mzero commented Mar 28, 2021

This bug, now 6 months fixed in the tinyusb repo, is still here. And because it is still here, it is still in the cores for Adafruit boards. Hence, Adafruit board users still have this bad bug, which means they cannot send SysEx messages.

Can we get the source code here refreshed from tinyusb?

@hathach
Copy link
Member

hathach commented Mar 29, 2021

thank for reminding this issue, there is lots of changes in the tinyusb stack. Sync it up will also need to re-test and bump up both the SAMD and nRF cores which involved mostly testing. We have been kept busy with lots of other works, though I will try my best to re-test, sync up and release these asap.

@hathach hathach transferred this issue from adafruit/Adafruit_TinyUSB_ArduinoCore May 18, 2021
@hathach
Copy link
Member

hathach commented May 25, 2021

should be fixed by after release 1.0.0

@hathach hathach closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants