Why are range and zip assigned to themselves

[evaherrada]

Does anyone know why this is done? Pylint 2.x doesn't like it and although it appears like there were disables put in to ignore the issues caused by this, I wanted to check before adding another disable.

Adafruit_CircuitPython_RSA/adafruit_rsa/_compat.py

Lines 43 to 45 in 39330c6

	# pylint: disable=redefined-builtin, invalid-name
	range = range
	zip = zip

Referencing main issue: adafruit/Adafruit_CircuitPython_Bundle#232

[evaherrada]

@kattni

[evaherrada]

Also, these are all non top-level imports that pylint 2.x doesn't like. This wasn't changed by black and pylint 1.9.2 is fine with it. I assume this is to save on resources.

Adafruit_CircuitPython_RSA/adafruit_rsa/key.py

Lines 259 to 260 in 39330c6

	from adafruit_rsa.tools.pyasn1.codec.der import decoder
	from adafruit_rsa.asn1 import AsnPubKey

Adafruit_CircuitPython_RSA/adafruit_rsa/key.py

Lines 272 to 273 in 39330c6

	from pyasn1.codec.der import encoder
	from rsa.asn1 import AsnPubKey

Adafruit_CircuitPython_RSA/adafruit_rsa/key.py

Lines 337 to 339 in 39330c6

	from adafruit_rsa.asn1 import OpenSSLPubKey
	from pyasn1.codec.der import decoder
	from pyasn1.type import univ

Adafruit_CircuitPython_RSA/adafruit_rsa/key.py

Line 477 in 39330c6

from adafruit_rsa.tools.pyasn1.codec.der import decoder

Adafruit_CircuitPython_RSA/adafruit_rsa/key.py

Lines 516 to 517 in 39330c6

	from pyasn1.type import univ, namedtype
	from pyasn1.codec.der import encoder

[evaherrada]

Personally, I think that we should either move these to top-level imports or just add a disable in each method that has such an import

[brentru]

@dherrada Let's try moving them to top-level imports.

[brentru]

@dherrada this may have been for Python2 compatibility within the python-rsa library which this is based on.

It's since been removed from their master branch's _compat.py:
sybrenstuvel/python-rsa@ded036c#diff-331cbe2ce57debdeab49e0d23b70d312L43

They can be removed, but will need to test prior to merging in to make sure it doesn't affect anything. Feel free to assign me to this.

[brentru]

This has been updated in #10 and merged into master. De-assigning then closing.