You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the request is an error, such as 404 for User not found (example url), then this code will attempt to parse the response into a datetime anyway.
It should makes sure the status code is 200 before attempting to parse. If it's not, it should throw an exception and include the response text in the exception to help with debugging. As it stands, this will raise a very unhelpful error:
Traceback (most recent call last):
File "code.py", line 44, in <module>
File "adafruit_pyportal.py", line 629, in get_local_time
File "adafruit_pyportal.py", line 625, in get_local_time
ValueError: invalid syntax for integer with base 10
This would be an excellent first-time issue for someone.
The text was updated successfully, but these errors were encountered:
theacodes
changed the title
get_local_time doesn't properly check the http response status code before attempting to parse the time
get_local_time doesn't properly check the http response status code before attempting to parse the time
Nov 27, 2019
@ladyada I'll leave it for a new contributor within the next 15 days as people's holiday purchases roll in. I'll patch/release by then if it doesn't get picked up.
Adafruit_CircuitPython_PyPortal/adafruit_pyportal.py
Line 618 in 81c8203
If the request is an error, such as
404
forUser not found
(example url), then this code will attempt to parse the response into a datetime anyway.It should makes sure the status code is
200
before attempting to parse. If it's not, it should throw an exception and include the response text in the exception to help with debugging. As it stands, this will raise a very unhelpful error:This would be an excellent first-time issue for someone.
The text was updated successfully, but these errors were encountered: