-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We probably should not change the case of the domain #129
Comments
Is there a specific test case that's holding us back from resolving this issue? If there isn't, happy to resolve this. @lemire |
It depends on whether RFC 1034 is still considered valid. |
Lowercasing domains is part of IDNA. It has also been a part of previous URL standards, so it is established practice. I suppose it means that specific advice from RFC-1034 is obsolete (I can't speak to whether the rest of it is still relevant). |
Also:
So I think we are probably good changing the case of the domain. |
Well. Yeah. I am going to close this issue, but the fact that the output is in lower case does not imply that we ought to discard the case. Still, I think that we will discard it. |
RFC 1034 : https://www.rfc-editor.org/rfc/rfc1034
I do not find anything at https://url.spec.whatwg.org/#url-parsing saying that we should lower the case. They refer to case-insensitve matching, but that can be accomplished by lowercasing the strings, but that's not the same thing as storing the lowercase version of the domain.
We should, similarly, check whether other strings that we manipulate should be stored with their case changed.
The text was updated successfully, but these errors were encountered: