From ab78b1c4a208e47bd41daf5f11a2b5b90cc3f51c Mon Sep 17 00:00:00 2001 From: Yue Wu Date: Fri, 27 Sep 2024 14:54:47 +0800 Subject: [PATCH 1/2] fix: pushModal not dispatched in GoCardless linking --- packages/desktop-client/src/gocardless.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/desktop-client/src/gocardless.ts b/packages/desktop-client/src/gocardless.ts index 3ae10e355d1..b9861626bcd 100644 --- a/packages/desktop-client/src/gocardless.ts +++ b/packages/desktop-client/src/gocardless.ts @@ -45,12 +45,14 @@ export async function authorizeBank( ) { _authorize(dispatch, upgradingAccountId, { onSuccess: async data => { - pushModal('select-linked-accounts', { - accounts: data.accounts, - requisitionId: data.id, - upgradingAccountId, - syncSource: 'goCardless', - }); + dispatch( + pushModal('select-linked-accounts', { + accounts: data.accounts, + requisitionId: data.id, + upgradingAccountId, + syncSource: 'goCardless', + }), + ); }, }); } From 4cffda3d2ea25568e29d4026826179517860e227 Mon Sep 17 00:00:00 2001 From: Yue Wu Date: Fri, 27 Sep 2024 13:25:44 -0700 Subject: [PATCH 2/2] chore: add PR release note --- upcoming-release-notes/3515.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 upcoming-release-notes/3515.md diff --git a/upcoming-release-notes/3515.md b/upcoming-release-notes/3515.md new file mode 100644 index 00000000000..3200097e69e --- /dev/null +++ b/upcoming-release-notes/3515.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [EtaoinWu] +--- + +Fix GoCardless linking (account selection window not appearing)