-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stale label not being added #299
Comments
nijel
added a commit
to nijel/stale
that referenced
this issue
Feb 3, 2021
This might help to understand some situations as described in actions#299.
nijel
added a commit
to nijel/stale
that referenced
this issue
Feb 4, 2021
When different stale period is used for issues and pull requests, this code uses wrong one. This was probably missed in actions#224 Fixes actions#299
nijel
added a commit
to WeblateOrg/meta
that referenced
this issue
Feb 4, 2021
There seems to be a bug in current actions/stale and it uses the default value for checking actual staleness of an issue. So use the lower value there. This will make marking PRs as stale earlier, but we don't have any stale right now. Hopefully it will get properly fixed in the action. See actions/stale#304 See actions/stale#299
It turns out to be caused by not properly working issue/pr delays.
I've changed the perameters in WeblateOrg/meta@761741d to use the shorter period in
Should be fixed by #304 |
nijel
pushed a commit
to nijel/stale
that referenced
this issue
Feb 4, 2021
hross
pushed a commit
that referenced
this issue
Feb 5, 2021
This might help to understand some situations as described in #299.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Stale label not being added at all in our repo. To give a specific example, let's take WeblateOrg/weblate#4746
On the last nightly run, the log contains the following entries:
So, the action sees the issue is old, gets correct stale days and sees that the label is not there. It just doesn't label it as stale.
Things most likely go wrong here:
stale/src/IssueProcessor.ts
Line 280 in f71123a
The question is how to figure out whether there is a bug in the action or there is something misconfigured on our side.
The text was updated successfully, but these errors were encountered: