Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

having versions-manifest.json MANIFEST_REPO_BRANCH configurable #449

Closed
cielavenir opened this issue Jul 1, 2022 · 8 comments
Closed

having versions-manifest.json MANIFEST_REPO_BRANCH configurable #449

cielavenir opened this issue Jul 1, 2022 · 8 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@cielavenir
Copy link

Description:

https://github.com/actions/setup-python/blob/main/src/install-python.ts#L13 forces to main, I'd like to use some older hash due to actions/python-versions#175

Justification:
I'm already using macOS arm64 cross compiler.

Are you willing to submit a PR?
Perhaps need some replies to actions/python-versions#114 (comment)

@cielavenir cielavenir added feature request New feature or request to improve the current logic needs triage labels Jul 1, 2022
@IvanZosimov IvanZosimov self-assigned this Jul 1, 2022
@IvanZosimov
Copy link
Contributor

Hi, @cielavenir 👋 ! We will investigate your feature request and get back to you with updates.

@IvanZosimov
Copy link
Contributor

Hi, @cielavenir 👋 ! Thank you for this issue, the thing is that the version-manifest.json from the main branch consists of the tested on our hosted runners python versions which are compatible to our hosted runners. Unfortunately we aren't going to make this version-manifest.json externally configurable.

By now I'm going to close this issue, If you have any additions or questions, feel free to ping us!

@cielavenir
Copy link
Author

@IvanZosimov On github runner macos-12, python 3.10 fails to build wheel due to broken Xcode.app path.

@IvanZosimov
Copy link
Contributor

@cielavenir, 👋 ! Could you please provide us with broader info about your current case? I'd suggest creating a new bug issue with a link to the public repo with a failing workflow.

@cielavenir
Copy link
Author

@IvanZosimov would you mind checking actions/python-versions#114 thoroughly?

@IvanZosimov
Copy link
Contributor

@cielavenir, the problem you mentioned occurred because we started to build python into a universal2 binary format. As you can see in the PR you mentioned above, this change brought a lot of issues to the customers and it was decided to temporarily disable it. Did you have any problems before we moved to universal2 bin format?

@cielavenir
Copy link
Author

@IvanZosimov No problem before, but I already started to build arm64 wheels, so the github action will start to fail

@IvanZosimov
Copy link
Contributor

@cielavenir, We are very sorry for that, but we have to temporarily disable universal2 in order not to break a lot of workflows (that are already existed) which don't have an option to use python compiled in universal2 format. We apologize for the temporary inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants