ghes support #157
Merged
ghes support #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ericsciple
commented
May 15, 2020
•
ericsciple
commented
- Remote auth token when calling Dotcom from GHES
- Make download from Releases best effort
ericsciple
commented
May 15, 2020
| @@ -4618,6 +4618,7 @@ const core = __importStar(__webpack_require__(470)); | |||
| const installer = __importStar(__webpack_require__(749)); | |||
| const auth = __importStar(__webpack_require__(202)); | |||
| const path = __importStar(__webpack_require__(622)); | |||
| const url_1 = __webpack_require__(835); | |||
There was a problem hiding this comment.
ignore index.js, review .ts
ericsciple
commented
May 15, 2020
| let info: INodeVersionInfo | null = null; | ||
|
|
||
| // | ||
| // Try download from internal distribution (popular versions only) |
There was a problem hiding this comment.
get info + download inside try/catch
The formatting rules bloat the line count. We might be on old formatting rules.
ericsciple
commented
May 15, 2020
ericsciple
commented
May 15, 2020
ericsciple
commented
May 15, 2020
ericsciple
commented
May 15, 2020
ericsciple
force-pushed
the
users/ericsciple/m262ghes
branch
from
f08ba32 to
d59bcf2
Compare
| } | ||
|
|
||
| // | ||
| // Extract | ||
| // | ||
| console.log('Extracting ...'); | ||
| let extPath: string; | ||
| info = info || ({} as INodeVersionInfo); // satisfy compiler, never null when reaches here |
ericsciple
commented
May 17, 2020
|
Wait for actions/toolkit#460 to merge then bump tool-cache |
ericsciple
force-pushed
the
users/ericsciple/m262ghes
branch
from
222d743 to
0c1123b
Compare
ericsciple
force-pushed
the
users/ericsciple/m262ghes
branch
from
0c1123b to
e37249e
Compare
bryanmacfarlane
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.