Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debt: Handle escaping arguments more easily #2083

Open
thboop opened this issue Aug 24, 2022 · 1 comment
Open

Debt: Handle escaping arguments more easily #2083

thboop opened this issue Aug 24, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request Runner Feature Feature scope to the runner

Comments

@thboop
Copy link
Collaborator

thboop commented Aug 24, 2022

Describe the bug
Currently, we do manual escaping in ProcessInvoker and its various overloads for arguments. We should move towards using the ArgumentList property which automatically handles escaping, as opposed to doing it by hand, which introduces opportunity of human error.

This is likely a large set of changes, we should put it behind a feature flag to ensure a safe rollout if we can.

See related prs in this area recently, and the source code for how we invoke process

@thboop thboop added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 24, 2022
@nikola-jokic nikola-jokic added the Runner Feature Feature scope to the runner label Oct 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Oct 9, 2023
@github-actions github-actions bot removed the Stale label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Runner Feature Feature scope to the runner
Projects
None yet
Development

No branches or pull requests

4 participants
@thboop @ruvceskistefan @nikola-jokic and others