-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gfortran #202
Comments
@certik sorry for the delay looking into this. I have a few questions that might help us decide whether we can include this or not:
thanks. |
@alepauly thanks a lot for the response. Here are the answers:
https://github.com/fortran-lang/fpm/blob/af56c5890cd28f051147e36fa3c1d8553ec944ea/.github/workflows/CI.yml
Yes, see the above examples that install it on the fly. The Windows image already ships it, but it is installed on macOS and Linux.
Here is an example on Linux: https://github.com/fortran-lang/fpm/runs/396877419, which adds 1m 29s to the build. Here is an example on macOS: https://github.com/fortran-lang/fpm/runs/396877427, which adds 28s to the build time.
Let me know if you have any other questions. |
@alepauly I'm a Homebrew maintainer, and, full disclosure, work on fortran-lang/stdlib. I came here for this same reason and I was thinking about working up a PR for this. Looking at the Linux environment there is an install script named My personal preference would be to install GFortran 8, but to make it consistent with other gcc tools we could easily install GFortran 7, 8 or 9 following the paradigm set in One question: Where is the macOS infrastructure defined? I don't see anything in the images/macos folder. It would be really nice to install graphviz and gcc by default on macOS. (gcc in homebrew is the same as gcc@9, the latest stable release and includes gfortran, and g++.) |
(Also, I have a number of public and private repos with workflows depending on gfortran) |
@zbeekman thanks for all the info. I've gone ahead and moved this to get done (and figure out #103 and #104 at the same time).
not sure why it's pinned to g++7, from what I can see only gcc 8 and 9 are still supported, so we should definitely upgrade. Based on yours and other requests we should probably go to 8 across all languages for consistency.
Unfortunately that's not public yet, we have some work to clean it up and make it public in this repository - so in the meantime we have to make all the changes to it. Do you want to open a new issue for graphviz so our team can look into adding it? I see you opened #335, I'll go ahead and add some detail there. thanks again. |
That sounds good to me. I'd also recommend renaming
It would be really awesome if that were documented in CONTRIBUTING.md, the README.md (both for the repo and the images/macos/README.md) and/or somewhere else logical. I spent a while hunting around to make sense of why there was nothing in the images/macos folder. Adding detail to #335 is helpful but a more prominent notice would be nice.
I'm going to take a look at the packages installed in macos runners and I'll open new issues for graphviz, and possibly gcc and/or gcc@8 if they're missing. But I have other fires to put out first. |
Will do, thanks for noting it. There's a few areas where docs could be very much improved in this repo, I'll add this to the list. |
Good day! |
Hello, All We have added gfortran for Ubuntu in #369 and MacOs. It should start rolling out early next week, once the rollout start it shows up as a pre-release here: https://github.com/actions/virtual-environments/releases After that it takes about 6-7 days to reach all accounts (assuming no delays). |
@certik the images have been rolled out. Could you check GFortran, please? |
@miketimofeev thanks for the heads up. I tested it in fortran-lang/fpm#37 and it works! So this issue is fixed, as far as I am concerned. Thank you everybody (@miketimofeev, @al-cheb, @ivan-nosar, @alepauly) for fixing it, and thanks @zbeekman for providing additional info. |
Is there a reason gfortran-10 isn’t included in the latest images? |
@junghans they probably install the version in Ubuntu 18.04, which is 7.5.0. |
|
Ok, in that case it should be possible to enable |
@junghans , no one has asked for it so we didn't add it. |
@maxim-lobanov see #1796 |
Tool information
sudo apt install gfortran
Virtual environments affected
Can this tool be installed during the build?
Yes. On Ubuntu:
On macOS::
On Windows: the image already has
gfortran
, no change necessary.Are you willing to submit a PR?
Yes! Once I figure out how to do install it (see previous point.) Update: figured it out, I'll see if I can submit a PR.
The text was updated successfully, but these errors were encountered: