Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create_timepoint] Add error swal #9502

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

victori444
Copy link
Contributor

@victori444 victori444 commented Dec 4, 2024

Brief summary of changes

In the Create Timepoint module, if there was a PHP error upon submission, the entered data would not save without any error message. This adds an error swal if a PHP error occurs

Testing instructions (if applicable)

  1. Revert the changes made in this PR to cause a PHP error
  2. In the Create Timepoint module of any candidate, create a new valid visit
  3. Submit and verify that the error swal appears
  4. Restore the changes in the create_timepoint class (such that there are no PHP errors) and check that new visits can be created

Link(s) to related issue(s)

@driusan
Copy link
Collaborator

driusan commented Dec 5, 2024

I'm trying to test this but I'm still getting a success swal.

Screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[create_timepoint] Success swal appears even on failure
3 participants