Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSONdata Instruments] The score_instrument.php script does not support JSON data instruments #7142

Open
ridz1208 opened this issue Nov 24, 2020 · 6 comments
Open

[JSONdata Instruments] The score_instrument.php script does not support JSON data instruments #7142

ridz1208 opened this issue Nov 24, 2020 · 6 comments
Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered

Comments

@ridz1208
Copy link
Collaborator

ridz1208 commented Nov 24, 2020 •
edited
Loading

The score_instrument.php tool queries the data with a hardcoded query looking for the instrument table instead of using the instrument's loadInstanceData function.

https://github.com/aces/Loris/blob/main/tools/data_integrity/score_instrument.php#L179

This behaviour prevents it from working with any non-SQL instrument.
@ridz1208 ridz1208 added Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered labels Nov 24, 2020
@ridz1208
Copy link
Collaborator Author

@CamilleBeau @pierre-p-s if you feel like having fun.

@driusan
Copy link
Collaborator

driusan commented Nov 24, 2020

For bonus points do it in bulk using #6869

@ridz1208 ridz1208 changed the title [JSONdata Instruments] The score_instrument.php script does not support JSON data instruements [JSONdata Instruments] The score_instrument.php script does not support JSON data instruments Dec 2, 2020
@ridz1208
Copy link
Collaborator Author

ridz1208 commented Dec 2, 2020

ouuuhh yeah thats a good one

@laemtl
Copy link
Contributor

laemtl commented Dec 12, 2020

Will I need this for Inhance? If so I can take a look.

@ridz1208
Copy link
Collaborator Author

@laemtl most likely yes

@ridz1208
Copy link
Collaborator Author

@laemtl did you ever get around to this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driusan @ridz1208 @laemtl