Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Recommending Hooks API before it is has been accepted in React #755

Closed
paultannenbaum opened this issue Oct 25, 2018 · 6 comments
Closed

Comments

@paultannenbaum
Copy link

paultannenbaum commented Oct 25, 2018

First off, thank you for the great library.

I realize that @acdlite is a core dev on the react team, but Is it smart to announce no future maintenance and recommending hooks when the feature is still a proposal and has not been accepted into the core react library? Would also love to see some examples on how you believe the new hooks api solves the same problems, as I personally am still not seeing the api to be as powerful as the composability of a library like recompose.

@istarkov
Copy link
Contributor

Have u read this https://reactjs.org/docs/hooks-custom.html ?

@istarkov
Copy link
Contributor

istarkov commented Oct 25, 2018

You will have much more freedom with hooks

@paultannenbaum
Copy link
Author

I had not, you are right this could help a lot.

Isn't this still just a proposal? Which means it may not be added to React core.

@sorahn
Copy link

sorahn commented Oct 26, 2018

I think it's coming no matter what, but the names / implementation might change slightly.

Facebook said they've been using it in prod for a month already.

@gaearon
Copy link

gaearon commented Nov 14, 2018

Nothing is changing in practice. Andrew’s wording was too strong but he didn’t mean the library would suddenly become unsupported.

Your code will continue to work, and new versions for newer React updates will continue to be released. And Andrew hasn’t personally been working on Recompose for two years so that hasn’t changed either.

See my reply in #756 (comment).

@paultannenbaum
Copy link
Author

Thanks @gaearon. I am going to close this issue as #756 seems to be discussing the same thing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants