update resource type to map[string]bool #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #992 +/- ##
==========================================
- Coverage 78.58% 78.46% -0.12%
==========================================
Files 224 224
Lines 5659 5657 -2
==========================================
- Hits 4447 4439 -8
- Misses 932 939 +7
+ Partials 280 279 -1
|
patilpankaj212
requested review from
cesar-rodriguez,
Rchanger and
nasir-rabbani
harkirat22
previously approved these changes
Aug 19, 2021
Rchanger
previously approved these changes
Aug 19, 2021
cesar-rodriguez
suggested changes
Aug 19, 2021
patilpankaj212
dismissed stale reviews from Rchanger and harkirat22
via
8e59f38
patilpankaj212
force-pushed
the
update_resource_type
branch
from
8cd6ee1 to
8e59f38
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
cesar-rodriguez
approved these changes
Aug 20, 2021
cesar-rodriguez
pushed a commit
that referenced
this pull request
Aug 20, 2021
This reverts commit 3e8d964.
patilpankaj212
pushed a commit
that referenced
this pull request
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resourcetype in metadata json fromstringtomap[string]booland made related changes in resource type filter specification.pending - add more items in resource types of a metadata json if applicable.