Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes supported Kustomize version (should be v4) #932

Merged
merged 3 commits into from
Aug 13, 2021
Merged

Fixes supported Kustomize version (should be v4) #932

merged 3 commits into from
Aug 13, 2021

Conversation

devang-gaur
Copy link
Contributor

Since #630 was merged, we had been using v4 of kustomize but declaring it as v3 support . This PR aims to fix that.

@codecov
Copy link

codecov bot commented Jul 16, 2021 •
edited
Loading

Codecov Report

Merging #932 (086fdf2) into master (5477227) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
- Coverage   78.93%   78.58%   -0.36%     
==========================================
  Files         221      224       +3     
  Lines        5413     5650     +237     
==========================================
+ Hits         4273     4440     +167     
- Misses        880      930      +50     
- Partials      260      280      +20
Impacted Files Coverage Δ
pkg/iac-providers/kustomize/v4/load-dir.go 71.69% <ø> (ø)
pkg/iac-providers/kustomize/v4/load-file.go 100.00% <ø> (ø)
pkg/iac-providers/kustomize/v4/types.go 100.00% <ø> (ø)
pkg/policy/kustomize.go 100.00% <ø> (ø)
pkg/policy/types.go 100.00% <ø> (ø)
pkg/iac-providers/kustomize.go 100.00% <100.00%> (ø)
pkg/iac-providers/output/types.go 100.00% <0.00%> (ø)
pkg/iac-providers/cft/v1/load-file.go 80.76% <0.00%> (ø)
pkg/iac-providers/kubernetes/v1/load-dir.go 72.72% <0.00%> (ø)
pkg/iac-providers/kubernetes/v1/load-file.go 71.87% <0.00%> (ø)
... and 6 more

@nasir-rabbani nasir-rabbani linked an issue Aug 4, 2021 that may be closed by this pull request
Integrity issue with Kustomize v4 support #956
Closed
@cesar-rodriguez cesar-rodriguez removed the request for review from jlk August 6, 2021 02:34
@cesar-rodriguez cesar-rodriguez changed the title kustomize version should be v4 Fixes supported Kustomize version (should be v4) Aug 6, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cesar-rodriguez cesar-rodriguez merged commit 05a65a3 into tenable:master Aug 13, 2021
@cesar-rodriguez cesar-rodriguez mentioned this pull request Aug 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nasir-rabbani nasir-rabbani nasir-rabbani approved these changes

@patilpankaj212 patilpankaj212 Awaiting requested review from patilpankaj212

@kanchwala-yusuf kanchwala-yusuf Awaiting requested review from kanchwala-yusuf

@williepaul williepaul Awaiting requested review from williepaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrity issue with Kustomize v4 support
3 participants
@devang-gaur @nasir-rabbani @cesar-rodriguez