Remove unnecessary KMS deletion window code #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
=======================================
Coverage 79.04% 79.04%
=======================================
Files 211 211
Lines 5150 5150
=======================================
Hits 4071 4071
Misses 834 834
Partials 245 245 |
|
Hey, @matt-slalom, I've looked into the related issue, and I think it does make sense to remove this policy. @harkirat22 could you also look into it once? |
gaurav-gogia
approved these changes
Jul 7, 2021
harkirat22
approved these changes
Jul 10, 2021
|
@matt-slalom and @gaurav-gogia LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deleted code seems to serve no purpose and, as written, will always produce false alerts. See #917 for discussion.