-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile support #849
Dockerfile support #849
Conversation
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
==========================================
+ Coverage 78.81% 79.10% +0.28%
==========================================
Files 216 220 +4
Lines 5272 5359 +87
==========================================
+ Hits 4155 4239 +84
- Misses 864 866 +2
- Partials 253 254 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a testfile demonstrating scan of a Dockerfile that includes multi-staging build
https://docs.docker.com/develop/develop-images/multistage-build/
9417c83
to
a82f352
Compare
a82f352
to
9b8e5a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a request to be generous with comments. Ideally, a new contributor should be able to understand the code only from the comments.
e87a1ce
to
8f7d7d5
Compare
8f7d7d5
to
ac64ef9
Compare
used in some files
488eeed
to
840cff4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a warning for when you specify the -i docker
flag and no Dockerfiles were found?
Yes, added changes for warning |
This test case has been pushed, you can review that |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Adds: Docker as an IaC Provider.
Result of scan with docker policies.