-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ID Field for AWS Policies' Metadata #831
Merged
gaurav-gogia
merged 2 commits into
tenable:master
from
gaurav-gogia:feature/aws_id_field_2
Jun 3, 2021
Merged
Add ID Field for AWS Policies' Metadata #831
gaurav-gogia
merged 2 commits into
tenable:master
from
gaurav-gogia:feature/aws_id_field_2
Jun 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav-gogia
requested review from
harkirat22,
kanchwala-yusuf,
Avanti19,
nasir-rabbani and
shreyas-phansalkar-189
June 1, 2021 12:15
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
+ Coverage 74.99% 78.22% +3.23%
==========================================
Files 113 162 +49
Lines 3463 4354 +891
==========================================
+ Hits 2597 3406 +809
- Misses 675 734 +59
- Partials 191 214 +23
|
pkg/policies/opa/rego/aws/aws_cloudtrail/AWS.CloudTrail.Logging.Low.009.json
Show resolved
Hide resolved
pkg/policies/opa/rego/aws/aws_cloudtrail/AWS.CloudTrail.Logging.Medium.004.json
Show resolved
Hide resolved
pkg/policies/opa/rego/aws/aws_cloudtrail/AWS.CloudTrail.Logging.Medium.007.json
Outdated
Show resolved
Hide resolved
pkg/policies/opa/rego/aws/aws_cloudtrail/AWS.CloudTrail.Logging.Medium.008.json
Outdated
Show resolved
Hide resolved
pkg/policies/opa/rego/aws/aws_cloudtrail/AWS.Config.Logging.Medium.0590.json
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
nasir-rabbani
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for terrascan policies where names match with SIAC policies
These changes are relevant only for AWS policies
id
field with new formatPR created for issue #805