Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID Field for AWS Policies' Metadata #831

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Add ID Field for AWS Policies' Metadata #831

merged 2 commits into from
Jun 3, 2021

Conversation

gaurav-gogia
Copy link
Contributor

Changes for terrascan policies where names match with SIAC policies

These changes are relevant only for AWS policies

  1. Add id field with new format
  2. Update severity
  3. Update category

PR created for issue #805

@gaurav-gogia gaurav-gogia added the policy Issue concerning policy maintainers. label Jun 1, 2021
@gaurav-gogia gaurav-gogia self-assigned this Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #831 (6f8057d) into master (b012204) will increase coverage by 3.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   74.99%   78.22%   +3.23%     
==========================================
  Files         113      162      +49     
  Lines        3463     4354     +891     
==========================================
+ Hits         2597     3406     +809     
- Misses        675      734      +59     
- Partials      191      214      +23     
Impacted Files Coverage Δ
pkg/iac-providers/terraform/commons/resource.go 66.66% <0.00%> (-4.17%) ⬇️
pkg/iac-providers/kubernetes/v1/normalize.go 88.57% <0.00%> (-1.91%) ⬇️
pkg/iac-providers/cft/v1/load-dir.go 100.00% <0.00%> (ø)
...ers/cft/config/kinesis-firehose-delivery-stream.go 71.42% <0.00%> (ø)
...er/iac-providers/cft/config/ecs-task-definition.go 100.00% <0.00%> (ø)
pkg/mapper/iac-providers/cft/config/ecs-service.go 100.00% <0.00%> (ø)
pkg/mapper/iac-providers/cft/config/ebs-volume.go 100.00% <0.00%> (ø)
pkg/iac-providers/cft.go 100.00% <0.00%> (ø)
...oviders/cft/config/secretsmanager-secret-policy.go 100.00% <0.00%> (ø)
pkg/mapper/iac-providers/cft/config/rds-cluster.go 100.00% <0.00%> (ø)
... and 42 more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gaurav-gogia gaurav-gogia merged commit b899922 into tenable:master Jun 3, 2021
@gaurav-gogia gaurav-gogia deleted the feature/aws_id_field_2 branch June 3, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants