Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix- panic when terraform list variable doesn't have a type #654

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

patilpankaj212
Copy link
Contributor

  1. fix panic for list with no type
  2. add tests for cty-converters

2. add tests for cty-converters
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #654 (adb8752) into master (114222a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   77.94%   77.99%   +0.05%     
==========================================
  Files         105      105              
  Lines        2607     2609       +2     
==========================================
+ Hits         2032     2035       +3     
+ Misses        427      426       -1     
  Partials      148      148              
Impacted Files Coverage Δ
.../iac-providers/terraform/commons/cty-converters.go 90.24% <100.00%> (+3.06%) ⬆️

@patilpankaj212 patilpankaj212 linked an issue Apr 12, 2021 that may be closed by this pull request
@kanchwala-yusuf kanchwala-yusuf merged commit 5abf9af into tenable:master Apr 13, 2021
@patilpankaj212 patilpankaj212 deleted the cty-tests branch May 5, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic: not a string
2 participants