Add v13 flag option for terraform iac #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devang-gaur
requested review from
patilpankaj212,
kanchwala-yusuf,
williepaul and
amirbenv
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 73.69% 73.70% +0.01%
==========================================
Files 93 93
Lines 2148 2149 +1
==========================================
+ Hits 1583 1584 +1
Misses 429 429
Partials 136 136
|
kanchwala-yusuf
suggested changes
Jan 18, 2021
| @@ -28,7 +28,7 @@ require ( | |||
| go.uber.org/zap v1.16.0 | |||
| golang.org/x/mod v0.4.1 // indirect | |||
| golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f | |||
| golang.org/x/tools v0.0.0-20210114065538-d78b04bdf963 // indirect | |||
| golang.org/x/tools v0.0.0-20210115202250-e0d201561e39 // indirect | |||
There was a problem hiding this comment.
We do not need to change our go mod files here
There was a problem hiding this comment.
was done by go mod vendor . wouldn't affect anything imo
kanchwala-yusuf
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.