Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds different exit code when issues are found #299

Merged
merged 2 commits into from
Aug 22, 2020
Merged

Conversation

cesar-rodriguez
Copy link
Contributor

This change will add an exit code of "3" whenever issues are found.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #299 into master will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
- Coverage   60.08%   59.95%   -0.13%     
==========================================
  Files          48       48              
  Lines         982      984       +2     
==========================================
  Hits          590      590              
- Misses        344      346       +2     
  Partials       48       48              
Impacted Files Coverage Δ
pkg/cli/run.go 0.00% <0.00%> (ø)

Copy link
Contributor

@williepaul williepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and won't affect API mode. We may want to look into common behaviors (if any) and maybe trigger handlers later on if we end up needing other codes/behaviors on exit

@williepaul williepaul merged commit d170c17 into master Aug 22, 2020
@williepaul williepaul deleted the feature/exitstatus branch August 22, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants