Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip policy download if -p flag used #1210

Merged
merged 1 commit into from
Mar 31, 2022
Merged

skip policy download if -p flag used #1210

merged 1 commit into from
Mar 31, 2022

Conversation

Rchanger
Copy link
Contributor

@Rchanger Rchanger commented Mar 31, 2022 •
edited
Loading

  • Skip policy init if a custom policy path is specified.
  • Skip docker login on non-master branch

@Rchanger Rchanger requested review from a team and bkizer-tenable as code owners March 31, 2022 10:15
@Rchanger Rchanger linked an issue Mar 31, 2022 that may be closed by this pull request
Terrascan creates ~/.terrascan even though policy directory is supplied #1209
Closed
@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #1210 (35d6c04) into master (655761a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
- Coverage   77.83%   77.82%   -0.02%     
==========================================
  Files         272      272              
  Lines        7642     7643       +1     
==========================================
  Hits         5948     5948              
- Misses       1344     1345       +1     
  Partials      350      350
Impacted Files Coverage Δ
pkg/cli/scan.go 73.52% <0.00%> (-2.23%) ⬇️

patilpankaj212
patilpankaj212 previously approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@patilpankaj212 patilpankaj212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@Rchanger Rchanger force-pushed the bugfix_terrascan_1209 branch from f2676b1 to 35d6c04 Compare March 31, 2022 16:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Rchanger Rchanger requested a review from patilpankaj212 March 31, 2022 16:17
@patilpankaj212 patilpankaj212 merged commit a6a6a37 into tenable:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patilpankaj212 patilpankaj212 patilpankaj212 approved these changes

@bkizer-tenable bkizer-tenable Awaiting requested review from bkizer-tenable bkizer-tenable is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terrascan creates ~/.terrascan even though policy directory is supplied
2 participants
@Rchanger @patilpankaj212