updating s3 bucket policies for v4 aws provider #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
=======================================
Coverage 78.32% 78.32%
=======================================
Files 271 271
Lines 7452 7452
=======================================
Hits 5837 5837
Misses 1280 1280
Partials 335 335 |
gaurav-gogia
approved these changes
Feb 28, 2022
|
@gaurav-gogia @harkirat22 It would be nice to revert the PR so that we quickly handle the issue, if I am correct. The unit test of the added policies was failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the changes that happened for S3 bucket with new version of AWS provider.
This PR also resolves #1162