Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to output normalized resource config with errors #1134

Merged
merged 6 commits into from
Feb 10, 2022

Conversation

nasir-rabbani
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1134 (71d19b2) into master (0fd6b7d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
+ Coverage   78.46%   78.53%   +0.06%     
==========================================
  Files         260      260              
  Lines        7193     7215      +22     
==========================================
+ Hits         5644     5666      +22     
  Misses       1214     1214              
  Partials      335      335              
Impacted Files Coverage Δ
pkg/cli/run.go 88.23% <100.00%> (+0.28%) ⬆️
pkg/cli/scan.go 75.75% <100.00%> (+0.75%) ⬆️
pkg/http-server/file-scan.go 84.55% <100.00%> (+1.51%) ⬆️
pkg/http-server/remote-repo.go 71.83% <100.00%> (+0.81%) ⬆️
pkg/k8s/admission-webhook/validating-webhook.go 83.89% <100.00%> (ø)
pkg/runtime/executor.go 91.46% <100.00%> (+0.32%) ⬆️

@nasir-rabbani nasir-rabbani force-pushed the config-with-err branch 3 times, most recently from 50e3151 to 90134c2 Compare February 9, 2022 12:10
@nasir-rabbani nasir-rabbani marked this pull request as ready for review February 9, 2022 13:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@patilpankaj212 patilpankaj212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@patilpankaj212 patilpankaj212 merged commit 08ec43b into tenable:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants