-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accounts/graphql-api without gql-modules #824
Comments
@sakulstra what part of this is accountsjs? Could you add a little bit more context? I've found (with nest-js/graphql) that it's easiest to take any other Graphql Types or schemas and create a new GraphQLModule with that schema that imports the AccountsJSGraphQLModule like this export const schema = new GraphQLModule({
extraSchemas: [anotherGraphQLSchema],
imports: [accountsJSGraphQLModule]
}).schemaAsync; Otherwise if you don't have other types you should be able to do I am going to be starting work on a Type-Graphql package for accounts - see #781 which is going to be re-worked. |
@NickBolles, one entry in While this probably works, I currently use another workaround which seems to work as well. typeDefs: mergeGraphQLSchemas(
modules.filter(m => m.typeDefs).map(m => m.typeDefs)
),
resolvers: mergeResolvers(
modules.filter(m => m.resolvers).map(m => m.resolvers)
), Anyhow, that's not really the point. I was wondering if gql-modules could be more an "opt-in" kind of thing as we're not planning to use it throughout the codebase. That said I like the idea behind |
I think this could be closed since it references a really old version of the library, and today you could totally use accountsJS without requiring gql-modules into your app or messing with it? |
We're trying to use accounts-js for a few weeks, but are constantly facing problems with the dependency on graphql-modules.
We don't use graphql-modules for anything else, but accounts-js.
gql-modules usage breaks our custom modules workflow with hard to debug issues we shouldn't face in first place.
Somehow the accounts.typeDefs destroys our subscription setup with:
errors.
Would it be possible to have a raw export for
graphql-api
not usinggraphql-modules
or sth similar?The text was updated successfully, but these errors were encountered: