Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate of "@desc does not work for field arguments #650" #695

Closed
FloatingFront opened this issue Mar 6, 2019 · 1 comment
Closed

Comments

@FloatingFront
Copy link

FloatingFront commented Mar 6, 2019

Environment

  • Elixir version (elixir -v):
    Erlang/OTP 21 [erts-10.1] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe]
    Elixir 1.8.1 (compiled with Erlang/OTP 21)

  • Absinthe version (mix deps | grep absinthe):
    absinthe 1.4.16 (Hex package) (mix)
    locked at 1.4.16 (absinthe) 0933e4d9
    absinthe_plug 1.4.2 (Hex package) (mix)
    locked at 1.4.2 (absinthe_plug) 01bf16f0
    absinthe_phoenix 1.4.2 (Hex package) (mix)
    locked at 1.4.2 (absinthe_phoenix) cb84c81b
    absinthe_relay 1.4.0 (Hex package) (mix)
    locked at 1.4.0 (absinthe_relay) 0c65cb40

Expected behavior

Adding description to fields should be reflected in the response.

Neither this:

 query do
    field :menu_items, list_of(:menu_item),
          description: "The list of available items on the menu" do
      resolve fn _, _, _ ->
        {:ok, Repo.all(Menu.Item)}
      end
    end
end

Nor this:

query do
    @desc "The list of available items on the menu"
    field :menu_items, list_of(:menu_item) do
      resolve fn _, _, _ ->
        {:ok, Repo.all(Menu.Item)}
      end
    end
end

does provide description in the response.

Issue 650 does mention this, but it puts @desc inline with the field, instead at the top,

Actual behavior

No description is generated in the response

@FloatingFront
Copy link
Author

I am closing this issue, as it is a duplicate of issue #650 "@desc does not work for field arguments" - sorry for the inconvenience, did not mean to create unnecessary duplicate issue entry.

@FloatingFront FloatingFront changed the title Is issue: "@desc does not work for field arguments #650" being ignored? Duplicate of "@desc does not work for field arguments #650" Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant