Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: (esbuild-based) application builder complains about webpack-specific code #21448

Closed
1 task done
hillin opened this issue Nov 25, 2024 · 0 comments
Closed
1 task done
Assignees

Comments

@hillin
Copy link

hillin commented Nov 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

This issue is related to #19607.

In the angular frontend, if we switch to @angular-devkit/build-angular:application and use registerLocaleForEsBuild instead of registerLocale, the compiler still complains:

vite/deps/@abp_ng__core_locale.js
87 |          /* webpackInclude: /[/\\](ar|cs|en|en-GB|es|de|fi|fr|hi|hu|is|it|pt|tr|ru|ro|sk|sl|zh-Hans|zh-Hant)\.(mjs|js)$/ */
88 |          /* webpackExclude: /[/\\]global|extra/ */
89 |          `@angular/common${localePath}`
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
90 |        ).then((val) => {
91 |          let module = val;
The above dynamic import cannot be analyzed by Vite.
See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.

Reproduction Steps

  • Create a new project with angular as the UI framework
  • in angular.json, change projects.<project-name>.architect.build.builder to @angular-devkit/build-angular:application
  • in app.module.ts, replace registerLocale with registerLocaleForEsBuild
  • run ng serve

Expected behavior

No response

Actual behavior

No response

Regression?

No response

Known Workarounds

No response

Version

9.0.0

User Interface

Angular

Database Provider

None/Others

Tiered or separate authentication server

None (Default)

Operation System

Windows (Default)

Other information

No response

@hillin hillin added the bug label Nov 25, 2024
@masum-ulu masum-ulu added this to the 9.0-patch-final milestone Jan 24, 2025
@masum-ulu masum-ulu self-assigned this Jan 24, 2025
@sumeyyeKurtulus sumeyyeKurtulus added hold Taken progress, but needs to wait something. and removed in-progress hold Taken progress, but needs to wait something. labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants