Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make obfuscated dll´s trim friendly #13373

Closed
sturlath opened this issue Jul 22, 2022 · 13 comments
Closed

Make obfuscated dll´s trim friendly #13373

sturlath opened this issue Jul 22, 2022 · 13 comments

Comments

@sturlath
Copy link
Contributor

I was trying to trim the Blazor project with <PublishTrimmed>true</PublishTrimmed> but hit this issue with the linker on abp.io dll´s , Blazor linking throws "Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object."

Can you try to make it trim friendly?

Version: 5.3.2 Commercial

@realLiangshiwei
Copy link
Member

I can't reproduce the problem, could you provide steps to reproduce?

image

@sturlath
Copy link
Contributor Author

@realLiangshiwei I sent you an email with the code to test

@realLiangshiwei
Copy link
Member

realLiangshiwei commented Jul 22, 2022

Hi,

The project you provided has many other package references, I think it might unelated to ABP, can you use CLI to create a new project to reproduce?

@sturlath
Copy link
Contributor Author

I just removed every package reference except for

  • Microsoft
  • Volo
  • Blazorise

and still get this error.

@sturlath
Copy link
Contributor Author

@realLiangshiwei this seems to be volo dotnet/linker#2896 (comment)

@realLiangshiwei
Copy link
Member

We will check it

@sturlath
Copy link
Contributor Author

Just checking @realLiangshiwei will this be check within version 6.0 or later? I´m trying everything to speed up my Blazor backend so possibly getting the size down within 6.0 would be great until Can abp Blazor be this fast will be looked at in the version 7 timeframe.

@realLiangshiwei
Copy link
Member

Hi,

It's in the 7.0 milestone

@stale
Copy link

stale bot commented Oct 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Oct 20, 2022
@sturlath
Copy link
Contributor Author

@realLiangshiwei will this be in 7.0? Just making sure it's not forgotten about

@stale stale bot removed the inactive label Nov 11, 2022
@realLiangshiwei
Copy link
Member

Yes, it will include in the 7.0 version.

@sturlath
Copy link
Contributor Author

@realLiangshiwei we tried this again in 7.0.1 as still have this issue

image

@realLiangshiwei
Copy link
Member

Hi @sturlath

We noticed and fixed this issue, you can waiting to the 7.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants