Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for chakra v3 #88

Open
abrenoch opened this issue Oct 28, 2024 · 5 comments · May be fixed by #89
Open

Support for chakra v3 #88

abrenoch opened this issue Oct 28, 2024 · 5 comments · May be fixed by #89

Comments

@abrenoch
Copy link

Chakra recently released their v3 - would love to see this repo updated to support it!

@aboveyunhai
Copy link
Owner

This library is standalone from chakra UI module-wise as I didn't include chakra as dependency (it might sound weird even though you still need to install chakra).
So unless there is an api breaking change from component or import level, I believe it should work though,
Need to test it out actually.

@abrenoch
Copy link
Author

This library is standalone from chakra UI module-wise as I didn't include chakra as dependency (it might sound weird even though you still need to install chakra). So unless there is an api breaking change from component or import level, I believe it should work though, Need to test it out actually.

Unfortunately there appears to have been substantial changes to both the imports and components of chakra: https://www.chakra-ui.com/docs/get-started/migration

I'm working on a PR at the moment actually, just running into some baffling issue with GH today that isn't allowing me to push changes to my own repo 🤕. Should have something to look at sooner than later!

@abrenoch abrenoch linked a pull request Oct 29, 2024 that will close this issue
@amralsaidy
Copy link

amralsaidy commented Dec 25, 2024

Unfortunately this message with chakra ui 3:
Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.
Check the render method of SingleDatepicker.
Any solution ?

@aboveyunhai
Copy link
Owner

Unfortunately this message with chakra ui 3: Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. Check the render method of SingleDatepicker. Any solution ?

Chakra V3 is very different from the V1-2, without a huge rewrite, it's impossible to use this lib in V3.
There is rewrite in progress actually resolves all the runtime error
#91 ,
but the styling changes and the broken behaviors in modal are currently unresolved issues.

@amralsaidy
Copy link

Is there a specific time for this update to be completed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants