Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importers without a vulnerable package list #449

Closed
Hritik14 opened this issue Apr 26, 2021 · 4 comments · Fixed by #525
Closed

Importers without a vulnerable package list #449

Hritik14 opened this issue Apr 26, 2021 · 4 comments · Fixed by #525

Comments

@Hritik14
Copy link
Collaborator

Hritik14 commented Apr 26, 2021

#436 deprecates the concept of fixed_package and now only the vulnerable packages are entered into the database. Many data sources do not provide with a list of vulnerable packages and only provide a fixed version.
Currently affected importers:

Future affected importers:

We cannot simply ignore these data sources. One approach would be to flag all the versions before the provided fixed version as vulnerable and enter those in the database. The meaning of only a fixed version could further be clarified at the data source's end.
This needs to be further discussed.

@Hritik14 Hritik14 mentioned this issue Apr 26, 2021
6 tasks
@pombredanne
Copy link
Collaborator

#436 deprecates the concept of fixed_package and now only the vulnerable packages are entered into the database. Many data sources do not provide with a list of vulnerable packages and only provide a fixed version.

Are you sure this is deprecating this ?

@pombredanne
Copy link
Collaborator

@Hritik14 so yes indeed #436 did deprecate the concept of fixed_package and now only the vulnerable packages are entered into the database. And in hindsight this is a problem and we need to revisit this ASAP.

@pombredanne pombredanne changed the title Importers without a vulnerable package list Store and evaluate version ranges - Importers without a vulnerable package list May 24, 2021
@pombredanne pombredanne changed the title Store and evaluate version ranges - Importers without a vulnerable package list Importers without a vulnerable package list May 24, 2021
@pombredanne
Copy link
Collaborator

See #140 (comment)

@pombredanne
Copy link
Collaborator

As an example when I look at https://github.com/mozilla/foundation-security-advisories/blob/c5f33af98294e441311fa9ec904001b09934af73/announce/2021/mfsa2021-27.yml#L4 we have a fixed package. We should support these with no impacted packages alright too.
Eventually this means all previous versions and that's confirmed with the range of CPEs in https://nvd.nist.gov/vuln/detail/CVE-2021-29968#range-6743855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants