Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable forge kinds #336

Open
abhinav opened this issue Aug 9, 2024 · 0 comments
Open

Configurable forge kinds #336

abhinav opened this issue Aug 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@abhinav
Copy link
Owner

abhinav commented Aug 9, 2024

Right now, the way we determine the code forge is by matching the remote URL.

For GitHub, it must be github.com, or whatever is configured with GITHUB_URL.

Per discussion in #330, a better UX for GHES would be the ability to specify that they're using a specific kind of forge (e.g. GHES), and then the GitHub URL is determined based on the Git remote, and the API URL guessed based on that.
@abhinav abhinav added the enhancement New feature or request label Aug 9, 2024
This was referenced Aug 9, 2024
Merged
Merged
abhinav added a commit that referenced this issue Aug 9, 2024
@abhinav
forge/github: Determine API URL from base URL if not set (#337)
b6ccc5f 
For GHES, usually the API URL is /api under the base URL.
So if the API URL is not set, and base URL is not github.com,
we can assume the API URL is $baseURL/api.

Users can still override this with the `spice.forge.github.apiUrl`
or `GITHUB_API_URL` environment variable.

Follow up to
#330 (comment)
Relates to #336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhinav