Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a custom class to the trix-editor via className prop is not possible #30

Closed
alejo4373 opened this issue May 4, 2021 · 3 comments
Closed

Adding a custom class to the trix-editor via className prop is not possible #30

alejo4373 opened this issue May 4, 2021 · 3 comments

Comments

@alejo4373
Copy link
Contributor

alejo4373 commented May 4, 2021 •
edited
Loading

I need the ability to pass a custom class name to <trix-editor> because I want to override a css property that is set via the default trix.css. More specifically I want to override min-height because I want the editor to have different heights at different times.

It looks like we could accomplish this through trixEditorOptions.

I'm open to collaborating on this further.
@abhaynikam
Copy link
Owner

@alejo4373 Sounds good to me. Please feel free to raise a PR. 😊

@alejo4373 alejo4373 mentioned this issue May 12, 2021
Merged
@alejo4373
Copy link
Contributor Author

What do you think of updating storybook? It took me some time to figure how to implement the new story with the older API. See the change in API here for how to add parameters and decorators.

@abhaynikam
Copy link
Owner

We can log a separate issue for upgrading Storybook. Closing this issue as PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhaynikam @alejo4373