Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement suggestion: append paper size to 'liked' filenames #375

Open
gatesphere opened this issue May 22, 2023 · 1 comment
Open

Enhancement suggestion: append paper size to 'liked' filenames #375

gatesphere opened this issue May 22, 2023 · 1 comment

Comments

@gatesphere
Copy link
Contributor

I tend to plot multiple outputs from my sketches on different paper sizes with different media, etc. It would be personally helpful if the filenames produced by clicking the 'like' button in the viewer would include a paper size tag, i.e. mysketch_liked_1_9inx12in.svg. This should probably be configurable so as to not break old workflows, but maybe it doesn't matter.

@abey79
Copy link
Owner

abey79 commented Jan 8, 2024

I feel that would be best achieved by some general purpose file naming pattern. That could by a class variable possibly set by the sketch class:

class MySketch(vsketch.SketchClass):
    FILE_NAME_PATTERN = "{sketch_name}...{page_size}.svg"

    ...

Of course, SketchClass would provide a default value that behaves like the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants