Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading LoRAs should disable mmap (LoRA + mmap causes segmentation fault) #107

Closed
horenbergerb opened this issue Apr 23, 2023 · 1 comment

Comments

@horenbergerb
Copy link

In the issue that implemented LoRAs in llama.cpp they say "Using --lora disables mmap since the models have to be modified anyway."

It seems like trying to load a LoRA in llama-cpp-python with mmap enabled causes a segmentation fault. Probably this package should copy the default behavior of llama.cpp and disable mmap when loading LoRAs.

@abetlen
Copy link
Owner

abetlen commented Apr 23, 2023

Good catch, will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants