Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry should not be a dependency but rather a peer dependency #57

Open
mwillbanks opened this issue Dec 21, 2022 · 1 comment · May be fixed by #62 or #71
Open

Sentry should not be a dependency but rather a peer dependency #57

mwillbanks opened this issue Dec 21, 2022 · 1 comment · May be fixed by #62 or #71

Comments

@mwillbanks
Copy link

Currently sentry is a dependency of this package, however, it should become a peer dependency since people may already have a package installed.
@andyrichardson andyrichardson linked a pull request Mar 25, 2023 that will close this issue
Draft
This was referenced May 23, 2024
Draft
Open
@glensc glensc linked a pull request Aug 27, 2024 that will close this issue
Draft
@glensc
Copy link
Collaborator

glensc commented Aug 27, 2024

This won't work the way this package is supposed to be installed: globally:

npm install pino-sentry -g

how do you handle peer dependencies there?

See install:

And cli usage:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwillbanks @glensc