From 157bedf2d42bd2c2c9a35e355839a48f99ce06ee Mon Sep 17 00:00:00 2001 From: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com> Date: Wed, 20 Jul 2022 09:55:33 -0400 Subject: [PATCH] Delete unused experimental TraceConfig (#411) Resolves https://github.com/open-telemetry/opentelemetry-proto/issues/410 I am not aware of any OpenTelemetry or non-OpenTelemetry codebase that uses the experimental TraceConfig. I suggest to remove it. It can be added back if we see the need for it in the future. The SDK configuration may also be achieved by different means, see https://github.com/open-telemetry/opentelemetry-specification/issues/2207 We need to keep this PR open for a while and circulate it widely to make sure we give enough opportunity to object the removal. --- .../proto/trace/v1/trace_config.proto | 79 ------------------- 1 file changed, 79 deletions(-) delete mode 100644 opentelemetry/proto/trace/v1/trace_config.proto diff --git a/opentelemetry/proto/trace/v1/trace_config.proto b/opentelemetry/proto/trace/v1/trace_config.proto deleted file mode 100644 index aae19c9a2..000000000 --- a/opentelemetry/proto/trace/v1/trace_config.proto +++ /dev/null @@ -1,79 +0,0 @@ -// Copyright 2019, OpenTelemetry Authors -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -syntax = "proto3"; - -package opentelemetry.proto.trace.v1; - -option csharp_namespace = "OpenTelemetry.Proto.Collector.Trace.V1"; -option java_multiple_files = true; -option java_package = "io.opentelemetry.proto.trace.v1"; -option java_outer_classname = "TraceConfigProto"; -option go_package = "go.opentelemetry.io/proto/otlp/collector/trace/v1"; - -// Global configuration of the trace service. All fields must be specified, or -// the default (zero) values will be used for each type. -message TraceConfig { - - // The global default sampler used to make decisions on span sampling. - oneof sampler { - ConstantSampler constant_sampler = 1; - - TraceIdRatioBased trace_id_ratio_based = 2; - - RateLimitingSampler rate_limiting_sampler = 3; - } - - // The global default max number of attributes per span. - int64 max_number_of_attributes = 4; - - // The global default max number of annotation events per span. - int64 max_number_of_timed_events= 5; - - // The global default max number of attributes per timed event. - int64 max_number_of_attributes_per_timed_event = 6; - - // The global default max number of link entries per span. - int64 max_number_of_links = 7; - - // The global default max number of attributes per span. - int64 max_number_of_attributes_per_link = 8; -} - -// Sampler that always makes a constant decision on span sampling. -message ConstantSampler { - // How spans should be sampled: - // - Always off - // - Always on - // - Always follow the parent Span's decision (off if no parent). - enum ConstantDecision { - ALWAYS_OFF = 0; - ALWAYS_ON = 1; - ALWAYS_PARENT = 2; - } - ConstantDecision decision = 1; -} - -// Sampler that tries to uniformly sample traces with a given ratio. -// The ratio of sampling a trace is equal to that of the specified ratio. -message TraceIdRatioBased { - // The desired ratio of sampling. Must be within [0.0, 1.0]. - double samplingRatio = 1; -} - -// Sampler that tries to sample with a rate per time window. -message RateLimitingSampler { - // Rate per second. - int64 qps = 1; -}