Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phoneUS filter from angular-filter #9

Open
a8m opened this issue Jan 27, 2017 · 2 comments
Open

Add phoneUS filter from angular-filter #9

a8m opened this issue Jan 27, 2017 · 2 comments

Comments

@a8m
Copy link
Owner

a8m commented Jan 27, 2017

see: https://github.com/a8m/angular-filter#phoneus

@rafaelss95
Copy link
Collaborator

rafaelss95 commented Jan 28, 2017

I commited a initial version on 5833ebd. By the way. I think we can do much more than a simple pipe for US phone, in other words, we can expand it and make it a general pipe for as many country as we can. I added just two countries on this initial version. What do you think about it and about the logic that I'm using in this pipe?

@a8m
Copy link
Owner Author

a8m commented Jan 28, 2017

I like it. great job

We need to take this logic and copy it to angular-filter. it just makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants