Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap new entrances to building contours #62

Closed
Zverik opened this issue Apr 4, 2022 · 2 comments
Closed

Snap new entrances to building contours #62

Zverik opened this issue Apr 4, 2022 · 2 comments
Labels
API Related to data processing and OSM API entrances Entrance editor
Milestone

Comments

@Zverik
Copy link
Owner

Zverik commented Apr 4, 2022

When an entrance is placed <10m from a building contour, merge it, adding the node to the way. There should be two changes in the pending uploads: for the entrance and for the building.

@Zverik Zverik added the entrances Entrance editor label Apr 4, 2022
@Zverik Zverik added this to Every Door Apr 4, 2022
@Zverik Zverik added this to the 0.2 milestone Apr 4, 2022
@Zverik Zverik moved this to Todo in Every Door Apr 4, 2022
@Zverik
Copy link
Owner Author

Zverik commented Apr 12, 2022

Actually we can do this without downloading all building contours. Just store the "snap to contour" flag in an OsmChange and after uploading everything, but before uploading entrances, download all building contours in a small radius for all entrances. And snap then.

The drawback would be the absence of an address hint in the snapping checkbox. We wouldn't know where the entrance will be snapped until after uploading.

@Zverik Zverik added the API Related to data processing and OSM API label Apr 19, 2022
@Zverik Zverik moved this from Todo to In Progress in Every Door Apr 21, 2022
@Zverik
Copy link
Owner Author

Zverik commented Apr 22, 2022

Done in 0.1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to data processing and OSM API entrances Entrance editor
Projects
Status: Done
Development

No branches or pull requests

1 participant