Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows users: help !] Finding ImageMagick automatically on windows #80

Closed
Zulko opened this issue Oct 12, 2014 · 1 comment
Closed
Labels
enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc.

Comments

@Zulko
Copy link
Owner

Zulko commented Oct 12, 2014

Just in case there are Windows users watching the project: on linux and mac the imagemagick executable is easy to access (it is simply called convert). But in windows there is a name conflict so the users need to enter the path to the binary themselves. This prevents windows users from installing with pip, and it seems to be difficult to do for python beginners and non-computer experts in general. The path to provide looks like this

C:\Program Files\ImageMagick-6.8.3-Q16\convert

I can easily imagine that there could be a way to auto-detect that file so that windows users would have nothing set manually. But I don't want to write it myself because I am not on windows, so that would be difficult to test. Could someone do that ?

As I see it it would consist in changing this part of config.py:

if IMAGEMAGICK_BINARY == 'auto-detect':

    if try_cmd(['convert'])[0]:
        IMAGEMAGICK_BINARY = 'convert'
    else:
        IMAGEMAGICK_BINARY = 'unset'

by adding:

if os.name == "nt":
    # find the file
    IMAGEMAGICK_BINARY = (# found file else 'unset')
elif try_cmd(['convert'])[0]:
    etc.
@Zulko Zulko added the enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. label Oct 12, 2014
@keikoro
Copy link
Collaborator

keikoro commented Feb 17, 2017

Looks like this issue was fixed by the linked (and already merged) PR and can thus be closed. Thanks again for the contribution, @carlodri.

@keikoro keikoro closed this as completed Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc.
Projects
None yet
Development

No branches or pull requests

2 participants