Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with proc being None #636

Closed
gyglim opened this issue Aug 22, 2017 · 0 comments · Fixed by #637
Closed

issue with proc being None #636

gyglim opened this issue Aug 22, 2017 · 0 comments · Fixed by #637

Comments

@gyglim
Copy link
Contributor

gyglim commented Aug 22, 2017

I have an issue coming from #630:

Stack trace:

  File "/usr/local/lib/python2.7/dist-packages/moviepy/Clip.py", line 514, in __exit__
    self.close()
  File "/usr/local/lib/python2.7/dist-packages/moviepy/video/io/VideoFileClip.py", line 125, in close
    self.reader.close()
  File "/usr/local/lib/python2.7/dist-packages/moviepy/video/io/ffmpeg_reader.py", line 182, in close
    self.proc.terminate()
AttributeError: 'NoneType' object has no attribute 'terminate'

Comes from https://github.com/Zulko/moviepy/blame/master/moviepy/video/io/ffmpeg_reader.py#L186
before the PR there was del self.proc instead. We should go back to that or initialize self.proc = None

Sample to reproduce:

with VideoFileClip(YOUR_VIDEO) as v:    
    with v.subclip(0,1) as s:
       pass
@ghost ghost closed this as completed in #637 Aug 22, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant